[RQ-4283] Remove API Client from legacy onboarding & workspace creation#81
Draft
Kanishkrawatt wants to merge 1 commit into
Draft
[RQ-4283] Remove API Client from legacy onboarding & workspace creation#81Kanishkrawatt wants to merge 1 commit into
Kanishkrawatt wants to merge 1 commit into
Conversation
… creation
The API Client is now a separate standalone product, but the Interceptor
app still surfaced it in onboarding and workspace creation, funneling
users into creating local workspaces (which only ever held API Client
files). Per epic RQ-4191, remove all API Client touchpoints from these
flows so onboarding offers only Interceptor:
- DesktopOnboardingModal / WelcomeCard: remove the "Start using API
Client" welcome card (expandable local-workspace create/open options)
and the FOLDER_SELECTION local-workspace-creation step it fed into;
drop the now-unused WorkspaceCreationProvider wrapper and the hooks
(useCreateDefaultLocalWorkspace / useOpenLocalWorkspace /
LocalWorkspaceCreateOptions / redirectToApiClient). "Skip" now simply
completes onboarding instead of creating a local API Client workspace
and redirecting to the API Client. Drop FOLDER_SELECTION from the
OnboardingStep enum.
- CreateWorkspaceModalOld: remove the entire "Local workspace" option
("only API client files are supported") and its dead local-workspace
creation code — the modal now creates team workspaces only.
- personaRecommendationData: remove the dead "Test API endpoints ->
API Client" recommendation entry.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Jira: RQ-4283 (epic RQ-4191)
The API Client is now a separate standalone product, but the Interceptor app still surfaced it in onboarding and workspace creation — funneling users into creating local workspaces (which only ever held API Client files). Per epic RQ-4191, this removes all API Client touchpoints from those two flows so onboarding offers only Interceptor.
Changes
DesktopOnboardingModal/WelcomeCard— removed the "Start using API Client" welcome card (the expandable card with local-workspace create/open options) and theFOLDER_SELECTIONlocal-workspace-creation step it fed into. Dropped the now-unusedWorkspaceCreationProviderwrapper and the API-client hooks (useCreateDefaultLocalWorkspace,useOpenLocalWorkspace,LocalWorkspaceCreateOptions,redirectToApiClient). "Skip" now simply completes onboarding instead of creating a local API-Client workspace and redirecting into the API Client. RemovedFOLDER_SELECTIONfrom theOnboardingStepenum.CreateWorkspaceModalOld— removed the entire "Local workspace" option ("only API client files are supported") and all its dead local-workspace creation code. The modal now creates team workspaces only, preventing local-workspace creation here.personaRecommendationData— removed the dead "Test API endpoints → API Client" recommendation entry.The welcome screen now shows a single option, "Intercept and Modify Web Traffic".
Verification
tsc --noEmit: no new type errors — the repo has a large pre-existing error baseline (1298); this branch has 2 fewer and none of them are in the changed onboarding files.api client/LocalWorkspaceCreateOptions/redirectToApiClientreferences in either flow.🤖 Generated with Claude Code